Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling unit tests should not disable install of libraries and binaries #79

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Enabling unit tests should not disable install of libraries and binaries #79

merged 2 commits into from
Feb 28, 2022

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Feb 19, 2022

If unit tests are enabled only the header file is installed.

@olifre
Copy link
Contributor

olifre commented Feb 27, 2022

Whoops, I only saw your PR after I submitted mine, since I only checked the issue list before :-(.
So of course merging this will also fix #82. I leave it to you to decide whether to incorporate anything from #83 here.

@djw8605 djw8605 merged commit 37e8b02 into scitokens:master Feb 28, 2022
@djw8605 djw8605 mentioned this pull request Feb 28, 2022
Merged
@olifre olifre mentioned this pull request Feb 28, 2022
Closed
@ellert ellert deleted the install branch March 1, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djw8605 djw8605 djw8605 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellert @olifre @djw8605