Use nightly wheels where available to run tests and support NumPy 2.0 #3427
Conversation
|
I think it should be another nightly test, not part of the nightly build of the scipp. Can you add a nightly test action or move it to the end? |
|
The tests here should fail as the code needs to be updated numpy2.0 The current run is with the nightly builds of the following deps: |
tests/variable_creation_test.py
Outdated
| @@ -671,7 +671,7 @@ def test_arange_datetime_from_str_raises_if_step_has_no_unit(): | |||
|
|
|||
|
|
|||
| def test_arange_datetime_from_str_raises_given_string_with_timezone(): | |||
| with pytest.raises(ValueError, match='timezone'): | |||
| with pytest.raises(UserWarning, match='timezone'): | |||
There was a problem hiding this comment.
|
There are a couple of more tests failing, I'll get back to this later :) |
MridulS
changed the title
| @@ -897,7 +897,7 @@ def test_bin_with_explicit_lower_precision_drops_rows_outside_domain(): | |||
| x = sc.linspace('x', 0.0, 1.0, 3, unit='m', dtype='float32') | |||
| da = table.bin(x=x) | |||
| size = da.bins.size().sum().value | |||
| table.coords['x'].values[0] = 2.0 * np.finfo(np.float32).max | |||
| table.coords['x'].values[0] = np.float64(2.0) * np.finfo(np.float32).max | |||
There was a problem hiding this comment.
Type promotion rules have changed: https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotion
|
With the changes in this PR and a scipp built with numpy2, mac, linux and windows passes the test suite with python 3.10 Some of the changes here are backward incompatible, but I can update the code to make it work with numpy < 2 too. To make sure we don't distribute broken scipp, we need to release scipp built with numpy2 once numpy makes a 2.0 release (16th June - numpy/numpy#24300 (comment)). We can also cut a release of scipp with an upper pin on numpy if we do want to move to numpy 2 directly. |
|
This is ready to be reviewed. The PR does 2 things
|
| if cls.__module__ == 'numpy' and cls.__name__[:4] == 'bool': | ||
| type_name = 'numpy.bool' | ||
| else: | ||
| type_name = cls.__name__ |
There was a problem hiding this comment.
Does this break compatibility with old files? If so, please add a script to https://github.com/scipp/scipp/tree/main/tools/migration
.buildconfig/ci-linux.yml
Outdated
| @@ -17,3 +18,4 @@ dependencies: | |||
| - tbb=2020.2.* | |||
| - tbb-devel=2020.2.* | |||
| - tox=3.25.0 | |||
| - numpy=2.0.0rc2 | |||
I'm not sure if we are testing against nightly builds of packages (where available) of scipp dependencies. Numpy 2.0 will have major breaking changes (which may or may not affect us).