Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image bounding box when coords are midpoints #361

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

nvaytet
Copy link
Member

@nvaytet nvaytet commented Sep 5, 2024

After the backend re-write, making an image with midpoint coordinates would clip off the edges of the image.
This PR fixes this.

Example:

import scipp as sc
import plopp as pp

da = pp.data.data2d()['y', :5]['x', :10]
da.plot()

Before:
Screenshot at 2024-09-05 09-01-33

After:
Screenshot at 2024-09-05 09-01-07

@nvaytet nvaytet merged commit 8915618 into main Sep 5, 2024
3 checks passed
@nvaytet nvaytet deleted the fix-image-bbox branch September 5, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants