Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a couple of missing optional dependencies #330

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add a couple of missing optional dependencies #330

merged 1 commit into from
Apr 18, 2024

Conversation

nvaytet
Copy link
Member

@nvaytet nvaytet commented Apr 18, 2024

Note that ipywidgets was anyway included by pythreejs, but if one day we decide to move away from that, we would still need ipywidgets for the widgets.

@MridulS
Copy link
Member

MridulS commented Apr 18, 2024

Can we make this non user editable?

@MridulS MridulS merged commit 47351e9 into main Apr 18, 2024
3 checks passed
@MridulS MridulS deleted the optional-deppendencies branch April 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MridulS MridulS MridulS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvaytet @MridulS