-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Add a hard coded width bound to canvas rendered as widgets #319
Conversation
The failure seems unrelated. I can't restart the runner. |
I now gave you the correct permissions, and restarted the build as well ;-) Edit: it seems the failure is consistent. I'm wondering if our CI setup is broken for PRs from forks?? I'll investigate. |
Yup, it is indeed. Seems like an issue people run in actions/checkout#551 |
I wonder if this would also remove the need for having e.g. Edit: it seems to help indeed. I think we can remove most or all of the |
I think the same fix could also apply to 2d figures, when using the |
@nvaytet updated for 2d canvas and removed the use of figsize in 3d examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs #320 for builds to pass
Fixes #169 (a hack-y one).
After some researching around about bouding canvases out of py3js it seems like this is the easiest
way of fixing the overflow problem of the canvas. A better solution would be to expose max_width from
py3js but I guess this is a minimal invasive change.
This does hard code the 80% width value but I guess we can expose that upstream to be user controllable
if the need arises.