Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use card previews in docs basics index #283

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Use card previews in docs basics index #283

merged 2 commits into from
Nov 24, 2023

Conversation

nvaytet
Copy link
Member

@nvaytet nvaytet commented Nov 24, 2023

Before:
Screenshot at 2023-11-24 14-58-52

After:
Screenshot at 2023-11-24 14-58-30

Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!


:::

::::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a link to saving-figures is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I didn't add it because I didn't have a good image for it.
As it's still in the left hand side menu, I thought it would be ok without it?

Also, if I want to have a card the same size as the other, I have to add two dummy/empty cards next to it.
I could of course just add a single card that spans the whole width?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would look like this
Screenshot at 2023-11-24 15-40-19

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the dummy cards be visible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I can force the number of columns
Screenshot at 2023-11-24 16-07-00

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 👍


:::

::::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 👍

@nvaytet nvaytet merged commit d2843c0 into main Nov 24, 2023
3 checks passed
@nvaytet nvaytet deleted the cards-in-docs-basics branch November 24, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants