Add two more gallery examples #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nvaytet
commented
Oct 24, 2023
nvaytet
commented
- Interactive masking from drawing rectangles on a 2d data
- Two scatter point clouds on the same scene with different opacities
jl-wynen
reviewed
Oct 24, 2023
| @@ -220,20 +220,18 @@ | |||
| # -- Options for nbsphinx gallery------------------------------------------ | |||
| notebook_root = 'gallery' | |||
| thumbnail_root = os.path.join('_static', 'gallery') | |||
| gallery_notebooks = [ | |||
| 'nyc-taxi', | |||
| 'masking-a-range', | |||
There was a problem hiding this comment.
Some notebooks have their thumbnail auto-generated (the ones that are making 2d plots)
| "source": [ | ||
| "# Interactive masking\n", | ||
| "\n", | ||
| "In this example, we will use a custom drawing tool to draw rectangles on a 2D figure.\n", |
There was a problem hiding this comment.
Maybe mention that this uses mpltoolbox already here because it is needed in the next cell.
Also, this requires the mpl backend.
There was a problem hiding this comment.
I removed the import of mpltoolbox below, as it was unused.
I am now only importing lower down.
docs/gallery/peeling-layers.ipynb
Outdated
| "tags": [] | ||
| }, | ||
| "source": [ | ||
| "We select high-value and low-value two data ranges,\n", |
There was a problem hiding this comment.
I don't understand this sentence. Typo?
jl-wynen
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.