Add mechanism for setting sample and detector bank offset in Zoom workflow #59
Conversation
SimonHeybrock
force-pushed
the
user-position-config
branch
from
83f7497
to
eed11ca
Compare
| @@ -69,6 +69,8 @@ | |||
| " sans.isis.CalibrationFilename: '192tubeCalibration_11-02-2019_r5_10lines.nxs',\n", | |||
| " sans.isis.Filename[sans.types.SampleRun]: 'ZOOM00034786.nxs',\n", | |||
| " sans.isis.Filename[sans.types.EmptyBeamRun]: 'ZOOM00034787.nxs',\n", | |||
| " sans.isis.SampleOffset: sc.vector([0.0, 0.0, 0.11], unit='m'),\n", | |||
There was a problem hiding this comment.
Are these mostly required because of the IDF mechanism in Mantid/ISIS?
Will the situation be better at ESS with the nexus geometry, or are we expecting the geometry in the files to not be updated for every experiment and often be out of date?
There was a problem hiding this comment.
I think ECDC wants to keep files up to date, but if that will be actually true in practice...
src/esssans/isis/components.py
Outdated
|
|
||
| from ..types import RawData, RunType | ||
|
|
||
| PixelMask = NewType('PixelMask', sc.Variable) |
There was a problem hiding this comment.
This is also defined in masking.py. Should it be defined only once?
src/esssans/isis/components.py
Outdated
| PixelMask = NewType('PixelMask', sc.Variable) | ||
|
|
||
|
|
||
| class ConfiguredRawData(sciline.Scope[RunType, sc.DataArray], sc.DataArray): |
There was a problem hiding this comment.
I'm not sure about the name. Immediately it wasn't very clear what it was meant to represent.
What kind of other configurations are we expecting apart from custom offsets? Should we have a name that is specific to applying offsets?
There was a problem hiding this comment.
Do you have a suggestion?
There was a problem hiding this comment.
RawDataWithComponentUserOffsets?
There was a problem hiding this comment.
Should we also rename the provider? I guess configure_raw_data made more sense when the output was called ConfiguredRawData?
Related to #52 (but not a fix since the end goal is to parse the file that contains this info).