Process multiple detector banks via param series #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs bugfix release of Sciline with scipp/sciline#150. [no ci]
nvaytet
reviewed
Apr 2, 2024
| pipeline = sciline.Pipeline(loki_providers_no_beam_center_finder(), params=params) | ||
| pipeline[BeamCenter] = _compute_beam_center() | ||
| pipeline.set_param_series(PixelMaskFilename, ['mask_new_July2022.xml']) | ||
| pipeline.set_param_series(NeXusDetectorName, ['larmor_detector']) |
There was a problem hiding this comment.
Can we also use e.g. twice the same bank, as I believe for now, only the
if len(data) == 1:
return data[0]code branch is being tested, which is a special case?
There was a problem hiding this comment.
Unfortunately we cannot, since for a param series the index is the same as the values, and the index must be unique. We could change everything to a param table, introducing an extra type for the row index.
Note that the other branch (of the helper function) is tested by the run-merge. But I agree that this is not ideal. I will try to write a unit test just for the merge function.
nvaytet
approved these changes
Apr 3, 2024
|
Will wait with merging until we can update to bugfix release of Sciline (for graph grouping). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83.
I could have done the bank and run merge in a single step. Currently it is not clear which option is better in terms of parallelism and memory use, this has to be explored in the future.
Needs bugfix release of Sciline with scipp/sciline#150.(done)