Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try enabling windows ci workflow #116

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Try enabling windows ci workflow #116

merged 5 commits into from
Oct 27, 2023

Conversation

mmghannam
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #116 (0370c4a) into main (3e2c6a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   74.96%   74.96%           
=======================================
  Files          13       13           
  Lines        1725     1725           
=======================================
  Hits         1293     1293           
  Misses        432      432           

@mmghannam mmghannam closed this Oct 27, 2023
@KarelPeeters
Copy link
Contributor

FYI getting this to work is probably as simple as adding $SCIPOPTDIR/lib to PATH.

Something like

$Env:PATH += ";$Env:SCIPOPTDIR/lib"

right before cargo build should do the trick.

@mmghannam mmghannam reopened this Oct 27, 2023
@mmghannam
Copy link
Member Author

Thanks for the suggestion @KarelPeeters, it's nice to have the support of a windows user 😄

@KarelPeeters
Copy link
Contributor

I resent the accusation that I'm a Windows user, I'd like to think of myself as more of a multi platform user! 🙂

My bad, it should have been /bin (which is where the .dll files are) instead of /lib (which is where the .lib files are, for static linking). Static linking could be something useful to support in the future, but for now to get CI working dynamic linking is enough.

@mmghannam
Copy link
Member Author

It works now, thanks @KarelPeeters for saving the windows CI 😄

@mmghannam mmghannam merged commit b136944 into main Oct 27, 2023
6 checks passed
@mmghannam mmghannam deleted the windows-ci branch October 27, 2023 14:38
@KarelPeeters
Copy link
Contributor

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants