Fix the Windows MSVC build #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally underlying u32. This fixes the build on Windows MSVC, where enums are represented as i32 instead.
* The file itself is moved into an ignored data directory, so it never shows up in VCS. * The model is dropped before deleting the file, so it can be deleted (this is important on Windows).
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 74.61% 74.96% +0.35%
==========================================
Files 13 13
Lines 1729 1725 -4
==========================================
+ Hits 1290 1293 +3
+ Misses 439 432 -7
|
mmghannam
reviewed
Oct 26, 2023
mmghannam
reviewed
Oct 26, 2023
|
Thanks a lot for your contribution! could you please also update the |
|
I added a new version (0.1.5) of |
|
I hope I added that to the right section of the changelog 😅 . |
Yeah, it's always a philosophical dilemma for me too 😄 Thanks again @KarelPeeters! |
|
Thanks for the quick merges! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114, also has some other small improvements.
Depends on scipopt/scip-sys#4 to actually fully build on windows, so maybe a version bump of the sys crate and a corresponding change in this
Cargo.tomlis necessary.