pkg/addr: add missing MustParseIA,AS,ISD functions #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
oncilla
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Reviewed 173 of 173 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lukedirtwalker)
oncilla
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Reviewable status:
lukedirtwalker
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Reviewed 173 of 173 files at r1, all commit messages.
Reviewable status:
Providing MustParseX along with ParseX is a typical pattern in Go. There was already addr.MustParseAddr, but MustParseIA and MustParseAS were only defined as helper function in the internal xtest package. Define addr.MustParseIA, MustParseAS, MustParseISD to replace the definitions in the xtest package. Remove the rarely used plural forms, xtest.MustParseIAs/ASes; simply typing this out instead seems perfectly appropriate.
lukedirtwalker
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing MustParseX along with ParseX is a typical pattern in Go. There was already addr.MustParseAddr (since #4346), but MustParseIA and MustParseAS were only defined as helper function in the internal xtest package.
Define addr.MustParseIA, MustParseAS, MustParseISD to replace the definitions in the xtest package.
Remove the rarely used plural forms, xtest.MustParseIAs/ASes; simply typing this out instead seems perfectly appropriate.