ci: include build version in file name of build artifacts #4525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the artifacts had static, generic names. This has always felt a bit clumsy, as downloading artifacts from multiple builds with a browser would usually result in automatically deduplicated file names like `scion(5).tar`. After learning how the buildkite agent can interpolate variables in the pipeline during the pipeline upload (https://buildkite.com/docs/pipelines/environment-variables#variable-interpolation), it seems easy to improve this. Now the artifacts include the version, matching the name of the artifacts in releases.
|
This change is |
jiceatscion
approved these changes
May 16, 2024
There was a problem hiding this comment.
Cool!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
jiceatscion
approved these changes
May 17, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the artifacts had static, generic names. This has always felt a bit clumsy, as downloading artifacts from multiple builds with a browser would usually result in automatically deduplicated file names like
scion(5).tar.After learning how the buildkite agent can interpolate variables in the pipeline during the pipeline upload (https://buildkite.com/docs/pipelines/environment-variables#variable-interpolation), it seems easy to improve this.
Now the artifacts include the version, matching the name of the artifacts in releases.