Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tentative description of CS API. #24

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

jiceatscion
Copy link
Contributor

@jiceatscion jiceatscion commented May 23, 2024

Documents connectRPC as the RPC protocol instead of the old gRPC/HTTP2/QUIC stack. Document service resolution minimally.

Fixes #15

This is a proposed place holder, until/unless we are comfortable documenting the work
from IETF117 as the new standard.
draft-dekater-scion-controlplane.md Show resolved Hide resolved
draft-dekater-scion-controlplane.md Outdated Show resolved Hide resolved
draft-dekater-scion-controlplane.md Outdated Show resolved Hide resolved
draft-dekater-scion-controlplane.md Outdated Show resolved Hide resolved
draft-dekater-scion-controlplane.md Outdated Show resolved Hide resolved
draft-dekater-scion-controlplane.md Outdated Show resolved Hide resolved
draft-dekater-scion-controlplane.md Show resolved Hide resolved
draft-dekater-scion-controlplane.md Show resolved Hide resolved
Mainly add a description of service resolution and more complete protos.
Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiceatscion jiceatscion merged commit 6625368 into main Jun 4, 2024
2 checks passed
@jiceatscion jiceatscion deleted the grpc_api_described branch June 4, 2024 08:55
@nicorusti
Copy link
Member

nicorusti commented Jun 4, 2024

Thanks a lot and sorry for my late review. LGTM, I Just fixed a reference and a word in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC & service discovery - dangling reference
3 participants