Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix computeAABB orientation mult #433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tinglei8
Copy link

@tinglei8 tinglei8 commented Dec 1, 2019

In Body.js computeAABB(): the order of quaternion multiplication is fixed.

Steps to reproduce computeAABB error with unmodified lib:

  1. create a body containing a cylinder shape.

  2. when creating the cylinder shape set its localRotation to 45 degrees around z axis.

  3. AABB of the body is not enlarged by tilt of the shape.

@tinglei8
Copy link
Author

tinglei8 commented Dec 8, 2019

added one fix for ray.checkCollisionResponse not affected by options

@swift502
Copy link

swift502 commented Dec 8, 2019

Thanks for these fixes.

stockhuman added a commit to pmndrs/cannon-es that referenced this pull request Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants