Router: fix scala.js style for binPack.callSite #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, how we handle `binpack.callSite=true` depended only on `optIn.configStyleArguments`, and `danglingParentheses.callSite` was ignored completely. Also, the declared `scala.js` style, which purported to depend on the existence of a break before closing parenthesis, wasn't properly done. Both opening and closing parentheses were output tucked in all cases but one, when both of them were dangling in the input (and the choice of whether to dangle or tuck depended solely on `configStyleArguments`). Now let's introduce a small modification, so that we can express more formatting alternatives, and fix `scala.js` style. Specifically, associate the two variants above with dangling parentheses in the disabled state. When it's enabled, determine whether to tuck or dangle on break before closing parenthesis. Also, apply config style when that parenthesis is dangling and `configStyleArguments` is disabled (because in the enabled state, it requires both parentheses to be dangling to be triggered).
tgodzik
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, how we handle
binpack.callSite=truedepended only onoptIn.configStyleArguments, anddanglingParentheses.callSitewas ignored completely.Also, the declared
scala.jsstyle, which purported to depend on the existence of a break before closing parenthesis, wasn't properly done.Both opening and closing parentheses were output tucked in all cases but one, when both of them were dangling in the input (and the choice of whether to dangle or tuck depended solely on
configStyleArguments).Now let's introduce a small modification, so that we can express more formatting alternatives, and fix
scala.jsstyle.Specifically, associate the two variants above with dangling parentheses in the disabled state.
When it's enabled, determine whether to tuck or dangle on break before closing parenthesis. Also, apply config style when that parenthesis is dangling and
configStyleArgumentsis disabled (because in the enabled state, it requires both parentheses to be dangling to be triggered).