Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatWriter: merge columns at different depth #3925

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

kitbellew
Copy link
Collaborator

Fixes #3465.

@kitbellew kitbellew requested a review from tgodzik April 11, 2024 16:30
@@ -1850,7 +1850,7 @@ case class Foo() {
case class Foo() {
def Foo(firstParam: Int, secondParam: String, thirdParam: Boolean) = ???
def Bar(abc: Int, deg: String, xyz: Boolean) = ???
def Baz(hijk: Int, lmnop: String) = ???
def Baz(hijk: Int, lmnop: String) = ???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a regression?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is the whole point. try to align some nested columns (each line has different number) but then align the top stuff the usual way.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@kitbellew kitbellew merged commit 150e5cd into scalameta:master Apr 12, 2024
9 checks passed
@kitbellew kitbellew deleted the 3465 branch April 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't align def and val on the same token
2 participants