Router: indent trailing fewer braces, too #3514
Conversation
Previously, we applied a space indent when fewer braces were followed by another select. This takes care of the case when there are no more selects.
|
@kitbellew Thank you so much for taking care of this! I really appreciate it. |
no problem. there will be another change proposed subsequently, to make some of it configurable. it still requires the compiler change proposed by Martin Odersky (and under review with Tomasz Godzik), as i didn't figure out a way to do this easily: (and i already mentioned that i don't like what it looks like :) ). |
| >>> | ||
| object a: | ||
| def f(): Unit = | ||
| List(1, 2, 3).foldLeft(1): | ||
| case (a, b) => a + b | ||
| case (a, b) => a + b |
There was a problem hiding this comment.
This looks like way too much indentation. Looks like it's applied 3 times, wouldn't really one be enough? The alternative with {} will have single indentation:
object a:
def f(): Unit =
List(1, 2, 3).foldLeft(1) {
case (a, b) => a + b
case (a, b) => a + b
}
There was a problem hiding this comment.
this example uses 4 as the main indent. so there's only one additional level added, to make way for a potential select continuation after it.
There was a problem hiding this comment.
We haven't yet agreed on the dotty PR, no? I having doubts about whether we should even merge it. If we don't does this change still make sense?
There was a problem hiding this comment.
i don't know. it fixes an inconsistency but you're right that both are not yet supported.
but if the dotty change isn't merged, we'll have a problem...
are you opposed to the change martin proposed?
There was a problem hiding this comment.
I think that change might hard to nail especially with the wierd 1-space rule.
There was a problem hiding this comment.
i asked about that space as it seemed unexpected. no documentation mentions that one can be within one space of a significant indentation rather than matching it exactly... does the code not match it exactly?
if he agrees with the half-open interval you're proposing, would that unblock it?
There was a problem hiding this comment.
if he agrees with the half-open interval you're proposing, would that unblock it?
I think that would be the most logical yeah.
There was a problem hiding this comment.
@tgodzik i would like to merge this change anyway. i have another pr ready, which makes this configurable, so if the compiler change is made, this is ready, and if not, there's a currently compatible alternative. wdyt?
Previously, we applied a space indent when fewer braces were followed by another select. This takes care of the case when there are no more selects.
Towards #3489.