Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better lens-like operations support #583

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Better lens-like operations support #583

merged 9 commits into from
Aug 14, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Aug 14, 2024

  • fix bug
  • add documentation for lens-like cases
  • add lens-like tests for total transformation
  • add lens-like tests for partial transformation
  • fix missing tests for matchingSome/matchingLeft/etc in *StdLibSpec
  • fix missing tests for matchingSome/matchingLeft/etc in *IntegrationSpec

@MateuszKubuszok MateuszKubuszok linked an issue Aug 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.75%. Comparing base (c1de957) to head (2022400).
Report is 9 commits behind head on master.

Files Patch % Lines
...er/rules/TransformProductToProductRuleModule.scala 89.47% 2 Missing ⚠️
...nternal/compiletime/datatypes/SingletonTypes.scala 0.00% 1 Missing ⚠️
...ompiletime/derivation/patcher/Configurations.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   86.73%   86.75%   +0.01%     
==========================================
  Files         154      154              
  Lines        5986     6068      +82     
  Branches      514      553      +39     
==========================================
+ Hits         5192     5264      +72     
- Misses        794      804      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok changed the title Better Lens-like operation support Better lens-like operations support Aug 14, 2024
@MateuszKubuszok MateuszKubuszok merged commit 6abf010 into master Aug 14, 2024
22 checks passed
@MateuszKubuszok MateuszKubuszok deleted the leses-support branch August 14, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macro is ignoring overrides in collections when From =:= Target
1 participant