Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport new publishing scripts based on sbt-ci-release #268

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Feb 26, 2020

No description provided.

@SethTisue
Copy link
Member

I assume your "help me backport module publishing to an earlier branch" offer at the Scala Spree didn't get any takers :-)

@lrytz lrytz force-pushed the publish-backport branch 3 times, most recently from ee68234 to 4528f0d Compare February 26, 2020 14:08
@lrytz
Copy link
Member Author

lrytz commented Feb 26, 2020

The updated MiMa seems to find some binary incompatibilities

[info] Compiling 22 Scala sources to /home/travis/build/scala/scala-parser-combinators/jvm/target/scala-2.12/test-classes ...

[error]  * static method numberParser()java.lang.ThreadLocal in class scala.util.parsing.json.JSON does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.util.parsing.json.JSON.numberParser")

[error]  * static method defaultNumberParser()scala.Function1 in class scala.util.parsing.json.JSON does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.util.parsing.json.JSON.defaultNumberParser")

[error]  * static method keywordCache()scala.collection.mutable.HashMap in class scala.util.parsing.json.JSON does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.util.parsing.json.JSON.keywordCache")

@Philippus does that look legitimate?

@Philippus
Copy link
Member

I think it could be an example of lightbend-labs/mima#388?

@SethTisue
Copy link
Member

Agree. Those sources didn't change, and 1.1.0 was built with 2.12.4. It's fine to exclude the failures.

@lrytz
Copy link
Member Author

lrytz commented Feb 28, 2020

@lrytz lrytz merged commit f8504d7 into scala:1.1.x Feb 28, 2020
@lrytz lrytz deleted the publish-backport branch February 28, 2020 15:04
@lrytz lrytz mentioned this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants