This repository has been archived by the owner on Feb 28, 2021. It is now read-only.
Skip unpublish on projects marked skip on publish #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seglo
commented
May 10, 2019
src/main/scala/BintrayRepo.scala
Outdated
| @@ -80,7 +80,8 @@ case class BintrayRepo(credential: BintrayCredentials, org: Option[String], repo | |||
| /** unpublish (delete) a version of a package */ | |||
| def unpublish(packageName: String, vers: String, log: Logger): Unit = | |||
| await.result(repo.get(packageName).version(vers).delete(asStatusAndBody)) match { | |||
| case (200, _) => log.info(s"$owner/$packageName@$vers was discarded") | |||
| case (200, _) => log.info(s"$owner/$packageName@$vers was discarded") | |||
| //case (404, _) => log.warn(s"$owner/$packageName@$vers was not found") | |||
There was a problem hiding this comment.
The alternative implementation. Warn when artifacts don't exist, but don't fail the build.
eed3si9n
approved these changes
May 10, 2019
seglo
commented
May 11, 2019
| @@ -80,7 +80,8 @@ case class BintrayRepo(credential: BintrayCredentials, org: Option[String], repo | |||
| /** unpublish (delete) a version of a package */ | |||
| def unpublish(packageName: String, vers: String, log: Logger): Unit = | |||
| await.result(repo.get(packageName).version(vers).delete(asStatusAndBody)) match { | |||
| case (200, _) => log.info(s"$owner/$packageName@$vers was discarded") | |||
| case (200, _) => log.info(s"$owner/$packageName@$vers was discarded") | |||
| case (404, _) => log.warn(s"$owner/$packageName@$vers was not found") | |||
There was a problem hiding this comment.
I'll include this anyway. Seems reasonable to just warn the user when an arifact is not found.
|
No problem! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a project defines
skip in publish := truethen we should skip it while unpublishing artifacts as well. Currently, sbt-bintray will throw an error for discard request which return a 404 from bintray. This occurs when a project that does not exist to be unpublished, as described in #167.An alternative would be to ignore artifacts that can't be unpublished and raise a warning log message instead of fatal error.