Skip to content
This repository has been archived by the owner on Feb 28, 2021. It is now read-only.

Fix #72: Respect maven patterns for sbt plugins #125

Closed
wants to merge 1 commit into from

Conversation

jvican
Copy link
Member

@jvican jvican commented Jul 27, 2017

Read discussion in #72 for context.

@jvican jvican requested a review from dwijnand July 27, 2017 12:55
@jvican
Copy link
Member Author

jvican commented Jul 27, 2017

I'm testing it locally, I will report whether this fixes it.

Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works.

@jvican
Copy link
Member Author

jvican commented Jul 27, 2017

It does work. The issue is that it fails because Bintray does not allow double _ in the path:

java.lang.RuntimeException: error uploading to ch/epfl/scala/sbt-release-early_2.10_0.13/0.0.1/sbt-release-early-0.0.1.pom: {"message":"Provided artifact path does not comply with Maven's convention"}

Of course, this maven path is supported by Sonatype, since we use it and synchronize to Maven Central.

I'm writing them an email. Hope this gets fixed soon in their API. And then we can merge.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's now an alternative PR #141, which looks to be more complete.

@jvican jvican closed this Jan 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants