feat: Support resize window #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianfeng92
commented
Aug 1, 2024
| currentHeight: number, | ||
| ) { | ||
| if (width > maxWindowSize || height > maxWindowSize) { | ||
| throw new WindowSizeRangeError(); |
There was a problem hiding this comment.
TestCafe has checked the input before. Only positive integer is allowed. However, there is no limit for max size. So here added one.
Meanwhile, TestCafe official provider is using MAX_SAFE_INTEGER as the maxWindowSize to validate the input. However, the error message is mismatched with the actual value, which is 2^53-1.
Considering real-world scenarios, setting it to 2^31-1 is good enough.
export const maxWindowSize = 2 ** 31 - 1;
mhan83
approved these changes
Aug 1, 2024
alexplischke
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Job example: https://app.saucelabs.com/tests/85b6389899714d53b8514a1a88cb3563#2
Notes: when getting and setting window size, TestCafe official provider is checking if the browser is jwp type and using
_getWindowSizeand_setWindowSize. These two methods are both deprecated and commented asThis command is deprecated and likely not supported by any browser.. They have been removed recently as well. Therefore, in this PR, only usebrowser.getWindowRectandbrowser.setWindowRectwhich are for W3C browser.