This repository has been archived by the owner on May 29, 2020. It is now read-only.
No explicit mixing for LESS #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks but now we have 16 failing tests. |
|
Grunt test failed on a clean checkout, so I didn't check it for my changes. I don't mind digging into the tests, but it's not clear from the docs what I should run? |
|
No, they are fine in master and there are instructions how to run tests. |
|
Sorry, my bad, must've overlooked something. I'll fix it! |
|
All green now! The |
|
Cool, thanks! |
|
|
sapegin
added a commit
that referenced
this pull request
Aug 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #309
Additionally, I moved the font-family in the bem template to the
:beforepseudo element. Having it on the.iconelement is unnecessary and tends to cause issues (the bootstrap template already has it like ehit).