Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIT-2023: Enable GitHub Actions support #2050

Merged

Conversation

harshanarayana
Copy link
Contributor

@harshanarayana harshanarayana commented Mar 7, 2021

FOR RELEASE AFTER 21.3

closes #2023

Possible Issues

  1. Unable to Retry individual test from a workflow. (Add ability to re-run single jobs actions/runner#432)

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #2050 (9c7cf54) into main (5ba43de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2050   +/-   ##
=========================================
  Coverage   92.133%   92.133%           
=========================================
  Files           38        38           
  Lines         3470      3470           
  Branches       572       572           
=========================================
  Hits          3197      3197           
  Misses         185       185           
  Partials        88        88           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba43de...9c7cf54. Read the comment docs.

@ahopkins
Copy link
Member

ahopkins commented Mar 7, 2021

looks like a good start. I'll pop in with some of my ideas later.

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ahopkins ahopkins added this to the v21.6 milestone Mar 8, 2021
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a release workflow that copies the one in sanic-router? Release to PyPI on creation of a new release tag in GH.

.github/workflows/pull-request.yml Outdated Show resolved Hide resolved
@harshanarayana
Copy link
Contributor Author

Can you add a release workflow that copies the one in sanic-router? Release to PyPI on creation of a new release tag in GH.

Yes. I will do that. I am actually considering creating an entirely new action dedicated just for sanic repo in general. Let me see how that effort goes.

@ahopkins
Copy link
Member

ahopkins commented Mar 8, 2021

What do you mean?

@harshanarayana
Copy link
Contributor Author

harshanarayana commented Mar 8, 2021

> What do you mean?

@ahopkins Instead of defining the github actions in each repo, I would rather create a series of reusable action and leverage them across for all sanic-org projects.

- name: Run ${{ matrix.action }} on ${{ matrix.python-version }}
  uses: sanic-org/sanic-actions@v2
  with:
    python-version: ${{ matrix.python-version }}
    action: ${{ matrix.action }}

This is all you need to include in your github workflow with right set of python Version + os matrix. We can have a reusable set of actions in sanic-org/sanic-actions and reuse them everywhere.

@ahopkins
Copy link
Member

@harshanarayana What is left to get this one going?

Base automatically changed from master to main March 23, 2021 00:47
@harshanarayana
Copy link
Contributor Author

@harshanarayana What is left to get this one going?

I just need to restructure this to use the new actions setup and then some minor workflow naming. A bit held up on office work for today and tomorrow. I will get this done and update the PR in another 2 days,.

@ahopkins
Copy link
Member

Sounds great.

@harshanarayana harshanarayana force-pushed the feature/GIT-2023-migrate-github-actions branch from eb30d5e to bae5695 Compare March 27, 2021 05:17
@harshanarayana harshanarayana force-pushed the feature/GIT-2023-migrate-github-actions branch from 0fab51e to 1440cf9 Compare March 27, 2021 06:57
@harshanarayana harshanarayana marked this pull request as ready for review March 27, 2021 12:30
@harshanarayana harshanarayana requested a review from a team as a code owner March 27, 2021 12:30
@harshanarayana harshanarayana requested a review from a team as a code owner March 27, 2021 15:19
@harshanarayana harshanarayana mentioned this pull request Mar 28, 2021
@harshanarayana
Copy link
Contributor Author

@ahopkins once we merge this, let us start by setting all the test from workflow as an optional test and run it for a while to see if there are any other kinks that need to be sorted before we take travis out and then configure the mandatory test pass criteria. Does that sound okay to every @sanic-org/core-devs

@harshanarayana
Copy link
Contributor Author

For now, I have added an optional way to configure the test retires and mark certain test for ignoring the failure like we did in Travis. BUt I am yet to find a clean way to mark the failed but ignored test as warning.

@ahopkins
Copy link
Member

ahopkins commented Apr 6, 2021

@ahopkins once we merge this, let us start by setting all the test from workflow as an optional test and run it for a while to see if there are any other kinks that need to be sorted before we take travis out and then configure the mandatory test pass criteria. Does that sound okay to every @sanic-org/core-devs

Yup. That was the plan.

@ahopkins ahopkins merged commit 1a352dd into sanic-org:main Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to GitHub Actions
2 participants