-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIT-2023: Enable GitHub Actions support #2050
GIT-2023: Enable GitHub Actions support #2050
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2050 +/- ##
=========================================
Coverage 92.133% 92.133%
=========================================
Files 38 38
Lines 3470 3470
Branches 572 572
=========================================
Hits 3197 3197
Misses 185 185
Partials 88 88 Continue to review full report at Codecov.
|
looks like a good start. I'll pop in with some of my ideas later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a release workflow that copies the one in sanic-router
? Release to PyPI on creation of a new release tag in GH.
Yes. I will do that. I am actually considering creating an entirely new action dedicated just for sanic repo in general. Let me see how that effort goes. |
What do you mean? |
> What do you mean? @ahopkins Instead of defining the github actions in each repo, I would rather create a series of reusable action and leverage them across for all - name: Run ${{ matrix.action }} on ${{ matrix.python-version }}
uses: sanic-org/sanic-actions@v2
with:
python-version: ${{ matrix.python-version }}
action: ${{ matrix.action }} This is all you need to include in your github workflow with right set of python Version + os matrix. We can have a reusable set of actions in |
@harshanarayana What is left to get this one going? |
I just need to restructure this to use the new actions setup and then some minor workflow naming. A bit held up on office work for today and tomorrow. I will get this done and update the PR in another 2 days,. |
Sounds great. |
eb30d5e
to
bae5695
Compare
0fab51e
to
1440cf9
Compare
@ahopkins once we merge this, let us start by setting all the test from workflow as an optional test and run it for a while to see if there are any other kinks that need to be sorted before we take travis out and then configure the mandatory test pass criteria. Does that sound okay to every @sanic-org/core-devs |
For now, I have added an optional way to configure the test retires and mark certain test for ignoring the failure like we did in Travis. BUt I am yet to find a clean way to mark the failed but ignored test as warning. |
Yup. That was the plan. |
FOR RELEASE AFTER 21.3
closes #2023
Possible Issues