Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix card db path #213

Merged
merged 3 commits into from
Feb 26, 2018
Merged

fix card db path #213

merged 3 commits into from
Feb 26, 2018

Conversation

eppinglen
Copy link
Member

No description provided.

@martinghunt
Copy link
Contributor

This will break on versions <= 1.2.1 of the download because they are bz2 not gz. I think changing the end of the regex to \.(gz|bz2) would work?

The next question is whether the extension in the filename is used in line 93 or not. If the correct extension is needed, then it will need to be captured by the regex and then used in line 88 so that the right extension is used.

@eppinglen
Copy link
Member Author

Yes, the regex solved that issue for all card versions. I did not know that all card versions have to be supported.

The tarfile module in python just checks if the extension name is valid. For unpacking it doesn't matter if it is bz2, gz or just tar. So there won't be a problem in line 93 and 88.

@martinghunt
Copy link
Contributor

Awesome! Thanks for that!

@ssjunnebo
Copy link
Contributor

Is this ok to merge?

@martinghunt
Copy link
Contributor

All fine with me, so long as older version downloads still work

@ssjunnebo ssjunnebo merged commit 379fbb3 into sanger-pathogens:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants