Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #114

Merged
merged 3 commits into from
Aug 1, 2016
Merged

Minor fixes #114

merged 3 commits into from
Aug 1, 2016

Conversation

satta
Copy link
Collaborator

@satta satta commented Jul 31, 2016

While preparing a Debian package for the 'new' ariba, I noticed that:

  • there was still a test that apparently needed a SPAdes installation present, and

  • in one of the fermi-lite extension's tests there was a typo in the input file name, leading to failed assertions during the build due to the number of input sequences being zero:

    test _run_fermilite when it fails ... python3: mrope.c:230: mr_insert_multi: Assertion `len > 0 && s[len-1] == 0' failed.
    

This PR addresses both issues.

Note that there might be alternative approaches here: make this case
an error, for example. This solution simply doesn't generate an
assembly, which could lead to the currently handled error condition.
@martinghunt martinghunt merged commit 981bdf0 into sanger-pathogens:master Aug 1, 2016
@satta satta deleted the ss34_fixes branch August 1, 2016 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants