Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate tags #212

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Propagate tags #212

wants to merge 2 commits into from

Conversation

dillydally414
Copy link

Purpose

Trying to tag some currently-untagged costs/resources that AWS is labeling as Fargate... If anyone has tf knowledge feel free to chip in.

Tickets

What Trello tickets (if any) are associated with this PR?

Contributors

Who worked on this PR? Tag them with their Github @username for future reference

Use the "Assignees" feature in Github

Feature List

Expand on the purpose - what does this code do, and how? This should be a list of the changes, more in-depth and technical

Notes (Optional)

Is there anything reviewers should note? Do we need to add something later? Any followups? Was this ticket easier/harder than predicted?

Reviewers

Primary reviewer:

  • Pick one primary reviewer
    • The team member with the most relevant knowledge about the code area this PR touches
    • NOT an author of the PR
    • If the primary reviewer is the project lead, select two primary reviewers
      • Goal: facilitate knowledge transfer to other team members
    • Primary reviewers are required to approve the PR before it can be merged

Primary:

Use the "Reviewers" feature in Github

Secondary reviewers:

  • Pick as many as appropriate — anyone who would benefit from reading the PR
    • Tag them using their Github usernames below

Secondary:

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 80.439%. remained the same
when pulling 66e8c5e on propagate-tags
into d81126a on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants