-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IsUrl seems to be broken with pydantic-2 #72
Comments
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this issue
Jul 6, 2023
Bug: samuelcolvin/dirty-equals#72 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Good catch, I'll look into it. |
samuelcolvin
pushed a commit
that referenced
this issue
Sep 3, 2023
Closes issue #72 Co-authored-by: Shagov <shagov@tochka.com>
#74 apparently does not fix this issue either.
|
There's a few problems here:
|
Ping. |
This was referenced Nov 10, 2023
I was able to fix this issue by next way. May be it helps for upstream. |
sorry, life has been pretty busy. Looking into this. |
samuelcolvin
added a commit
that referenced
this issue
Nov 14, 2023
samuelcolvin
added a commit
that referenced
this issue
Nov 14, 2023
samuelcolvin
added a commit
that referenced
this issue
Nov 14, 2023
fix #72 Ended up having to do a bunch of things at the same time to get tests to pass: * drop 3.7 (added 3.12 at the same time) * uprev deps * uprev pydantic requirement to >2 * switch `IsUrl` to assume pydantic 2
Thank you to you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After upgrading to
pydantic-2.0.2
, I'm getting the following test failures:They pass after downgrading pydantic to
<2
.The text was updated successfully, but these errors were encountered: