Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small clippy lint for Rust 1.68 #242

Merged
merged 3 commits into from
Mar 10, 2023
Merged

small clippy lint for Rust 1.68 #242

merged 3 commits into from
Mar 10, 2023

Conversation

Pat-Lafon
Copy link
Contributor

Only a small change for the new Rust release.

I'll note that there is an additional future-incompat warning that we hit because of the current version of lalrpop. rust-lang/rust#103418 lalrpop/lalrpop#701

In one sense, it's kind of a non-issue because it doesn't hold up the ci and I think this can only become a hard error over an edition change. On the other hand, it's a little disconcerting if lalrpop isn't getting much attention from the maintainers these days.

I would expect that a (new?) maintainer will arise who can cut a new lalrpop release which will resolve this issue. Otherwise this could motivate a switch in parsers.

@Pat-Lafon
Copy link
Contributor Author

Speaking of being unmaintained, apparently actions-rs is suffering from this issue. Here there seems to be a good amount of movement to dtolnay/rust-toolchain like with rust-lang/regex@bbb9dac so I feel reasonably confident in switching over.

@sampsyo
Copy link
Owner

sampsyo commented Mar 10, 2023

Very nice; many thanks, as always!

It's really too bad about lalrpop; there are just not that many good options for solid parser generators in the ecosystem (is pest the only viable alternative? There's Chumsky but that's a very different style).

And thanks for switching to rust-toolchain; looks great!

@sampsyo sampsyo merged commit 26ad367 into sampsyo:main Mar 10, 2023
@Pat-Lafon
Copy link
Contributor Author

I've explored using https://github.com/hydro-project/rust-sitter to leverage the tree-sitter ecosystem but it doesn't have the same kind of maturity yet(being built into the proc-macro attribute system of Rust does have a certain appeal/benefits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants