Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Trigger CI for #4468: perf(template-compiler): static-optimize on event listener object #4520

Closed
wants to merge 22 commits into from
Closed

[DO NOT MERGE] Trigger CI for #4468: perf(template-compiler): static-optimize on event listener object #4520

wants to merge 22 commits into from

Conversation

nolanlawson
Copy link
Collaborator

External contributors do not have access to CI secrets. This PR serves as a workaround to trigger CI with secrets for #4468.

cardoso and others added 22 commits August 20, 2024 11:03
@cardoso
perf(template-compiler): static-optimize on event listener object
9c351e3
@cardoso
perf(template-compiler): remove individual handler caching
dab5ce8
@cardoso
perf(template-compiler): use logical or assignment
db92d72
@cardoso
perf(template-compiler): revert logical or assignment back to short-c…
c11f811 
…ircuit
@cardoso
perf(template-compiler): use for loop instead of fromEntries + map
c2514fa
@nolanlawson
test: add fixture test
49c0252
@nolanlawson
fix: prettier
5d44374
@cardoso
Merge branch 'master' of https://github.com/salesforce/lwc into optim…
ac89e65 
…ize-on
@cardoso
fix(template-compiler): prevent handler memoization if it is outside …
12a1b9f 
…component scope
@cardoso
Merge branch 'optimize-on' of https://github.com/cardoso/lwc into opt…
4c09a5a 
…imize-on
@cardoso
fix(template-compiler): memoize only individually-memoizable listeners
3e470dc
@cardoso
chore(template-compiler): clean up genEventListeners
06f2ad5
@cardoso
chore(template-compiler): spelling memorization -> memoization
a183c7f
@cardoso
chore(template-compiler): add comments to genEventListener
329bf6f
@cardoso
test(template-compiler): mixed event listeners accessing different sc…
9806e12 
…opes
@nolanlawson
Merge remote-tracking branch 'origin/master' into optimize-on
c6051c1
@cardoso @nolanlawson
Update packages/@lwc/template-compiler/src/codegen/codegen.ts
4d9f24c 
Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
@cardoso @nolanlawson
Update packages/@lwc/template-compiler/src/codegen/codegen.ts
5c6e6a4 
Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
@cardoso
Merge branch 'master' of https://github.com/salesforce/lwc into optim…
a58b341 
…ize-on
@cardoso @nolanlawson
Update packages/@lwc/template-compiler/src/codegen/codegen.ts
b8d50c2 
Co-authored-by: Nolan Lawson <nolan@nolanlawson.com>
@cardoso
chore(template-compiler): use single if/else instead of 2 ternary expr
9a54ef4
@cardoso
test(integration-karma): memoization of mixed-scope handlers
9f80b51
@nolanlawson nolanlawson requested a review from a team as a code owner September 3, 2024 23:05
@nolanlawson nolanlawson closed this Sep 3, 2024
@nolanlawson nolanlawson deleted the external-contributor-ci-workaround/pr-4468 branch September 3, 2024 23:05
@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

Test stage cannot be run since workflow branch does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolanlawson @cardoso