Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Add test for draft orders #5194

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[E2E] Add test for draft orders #5194

wants to merge 3 commits into from

Conversation

szczecha
Copy link
Member

@szczecha szczecha commented Oct 2, 2024

This PR adds new tests for draft orders:

  1. To Manage products on draft order: add, change the quantity, remove the product from draft order SALEOR_218
  2. To place a basic order for non-existing customer SALEOR_217

This test are part of project for incerase draft orders e2e test coverage: https://linear.app/saleor/project/increase-test-coverage-for-draft-orders-fd3163d72054/issues

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 3274a6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5194 October 2, 2024 19:13 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5194 October 2, 2024 19:43 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5194 October 3, 2024 15:32 Destroyed
@szczecha szczecha marked this pull request as ready for review October 4, 2024 07:21
@szczecha szczecha requested review from a team as code owners October 4, 2024 07:21
async typeAndSelectCustomerEmail(customerEmail = "customer@example.com") {
await this.searchCustomerInput.fill(customerEmail);
await this.selectCustomerOption.locator(`text=${customerEmail}`).click();
await this.waitForDOMToFullyLoad();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I'd not recommend use waitForDOMToFullyLoad as it not working after initial page load, try to use build in pw feature to wait for element

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants