Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align modals - always show close button #5183

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

poulch
Copy link
Member

@poulch poulch commented Sep 27, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Sep 27, 2024

🦋 Changeset detected

Latest commit: 65cbe1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5183 September 27, 2024 10:24 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 September 30, 2024 10:33 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 1, 2024 09:51 Destroyed
Cloud11PL
Cloud11PL previously approved these changes Oct 1, 2024
@poulch poulch added run e2e Runs cypress end-to-end tests run pw-e2e and removed run e2e Runs cypress end-to-end tests labels Oct 1, 2024
@github-actions github-actions bot temporarily deployed to pr-5183 October 1, 2024 14:06 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 1, 2024 17:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 1, 2024 18:31 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 1, 2024 19:51 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 4, 2024 09:57 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 4, 2024 10:27 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 4, 2024 11:25 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 4, 2024 12:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5183 October 5, 2024 17:27 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants