Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for python sets to be counted as sets #38602

Merged
merged 5 commits into from
Sep 15, 2024
Merged

Allow for python sets to be counted as sets #38602

merged 5 commits into from
Sep 15, 2024

Conversation

thecaligarmo
Copy link
Contributor

@thecaligarmo thecaligarmo commented Sep 3, 2024 •
edited by mantepse
Loading

Fixes Issue #32265

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 8035d12; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tscrim
tscrim approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine since all it needs to do is iterate over the object. So basically we add an additional check for set (and frozenset).

src/sage/combinat/subset.py Outdated Show resolved Hide resolved
src/sage/combinat/subset.py Outdated Show resolved Hide resolved
@tscrim
Copy link
Collaborator

tscrim commented Sep 3, 2024

Once this change is done, then this is positive review.

thecaligarmo and others added 2 commits September 3, 2024 15:58
@thecaligarmo @tscrim
Update src/sage/combinat/subset.py
65d09ce 
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
@thecaligarmo @tscrim
Update src/sage/combinat/subset.py
234acb6 
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
@thecaligarmo
Copy link
Contributor Author

I think this is fine since all it needs to do is iterate over the object. So basically we add an additional check for set (and frozenset).

That looks good for me. I've used that instead.

@thecaligarmo
Copy link
Contributor Author

Just ran through and tested everything on my machine and it's all running good. I fixed one style issue (space after comma) and it looks good on my end now.

tscrim
tscrim approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
sagemathgh-38602: Allow for python sets to be counted as sets
a0db75e 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes Issue sagemath#32265


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38602
Reported by: Aram Dermenjian
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 10, 2024
sagemathgh-38602: Allow for python sets to be counted as sets
60dd032 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes Issue sagemath#32265


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38602
Reported by: Aram Dermenjian
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 12, 2024
sagemathgh-38602: Allow for python sets to be counted as sets
e90381f 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes Issue sagemath#32265


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38602
Reported by: Aram Dermenjian
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit ae77953 into sagemath:develop Sep 15, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thecaligarmo @tscrim @vbraun