Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dual subdivision and weight vectors for tropical variety #38536

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

verreld7
Copy link
Contributor

@verreld7 verreld7 commented Aug 20, 2024

This PR introduces some new methods in TropicalVariety related to dual subdivision and weight vectors.

Summary of changes:

  1. Add dual_subdivision in TropicalVariety: return the dual subdivision for any tropical variety as a Graph object

  2. Add _components_of_vertices in TropicalCurve: intermediate method the help calculate weight vectors

  3. Add weight_vectors in TropicalCurve: return the weight vectors of each vertex

  4. Add weight_vectors in TropicalSurface: return the weight vectors of each unique line of intersection

  5. Add a few methods related to dual subdivision of tropical curve such as:

    • is_smooth
    • is_simple
    • genus
    • contribution

CC: @tscrim

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#37962: issues related to this PR
#38291: continuation of this PR

Copy link

github-actions bot commented Aug 22, 2024

Documentation preview for this PR (built with commit d4c1251; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim tscrim self-requested a review August 27, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants