Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using reserved min and max in two files #38516

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

fchapoton
Copy link
Contributor

and other minor code details in the modified files

also some doctest formatting

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Aug 16, 2024

Documentation preview for this PR (built with commit a7e106c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The lint errors are not related to the changes done here.

@fchapoton
Copy link
Contributor Author

the linter failure is bizarre ; I have not seen it elsewhere..

@fchapoton
Copy link
Contributor Author

du coup, je prefere reparer le linter ici..

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. LGTM.

@dcoudert
Copy link
Contributor

May be you should add tad CI Fix to this PR to make it applied to other PRs ? this would avoid reporting the same lint errors in all PRs.

@fchapoton
Copy link
Contributor Author

I dare not. Maybe there are now "rules" to do that. I have no idea.

@GiacomoPope GiacomoPope added the p: CI Fix merged before running CI tests label Aug 21, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 27, 2024
    
and other minor code details in the modified files

also some doctest formatting

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38516
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 57e9920 into sagemath:develop Sep 3, 2024
19 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Sep 3, 2024
@fchapoton fchapoton deleted the avoid_min_max branch September 4, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: CI Fix merged before running CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants