-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile everything with meson #36524
base: develop
Are you sure you want to change the base?
Conversation
This reverts commit 9694046.
Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
Note that the |
I don't see how this is relevant here. I'm trying to build the full sagelib with meson. Just started with a small part to make reviewing easier |
Just a heads up that the monolithic build is going to go away very soon. So it would be unwise to design a new system for the monolithic library. |
From PR 'Compile everything with meson' (sagemath#36524 at 46bc6b4 (2023-12-31)
…ything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
….build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
…son.build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
From PR 'Compile everything with meson' (sagemath#36524 at 46bc6b4 (2023-12-31)
…ything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
….build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
…son.build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
Here is how I'm trying to test this. I create a standard venv, activate it, and pip install few things there, like scipy, pytest, etc. Then there I run
which seems to indicate that it refuses to use packages etc from the venv (as it won't find pytest, and won't find numpy). If instead I invoke
that is, again somewhere the python packages path gets poisoned, I suppose. |
It does not matter what you have in your venv. Build isolation. |
From PR 'Compile everything with meson' (sagemath#36524 at 46bc6b4 (2023-12-31)
…ything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
….build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
…son.build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
From PR 'Compile everything with meson' (sagemath#36524 at 46bc6b4 (2023-12-31)
…ything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
….build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
…son.build files from PR Compile everything with meson (sagemath#36524 at 46bc6b4 (2023-12-31) squashed on 10.3.beta4
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Broken in sagemath#37287 - Reported in sagemath#37434 (comment) - Reported in sagemath#36524 (comment) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38515 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Broken in sagemath#37287 - Reported in sagemath#37434 (comment) - Reported in sagemath#36524 (comment) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38515 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
Add meson configuration to compile sagelib with meson. Basic developer docs are added as well (meant as background info, not real installation instructions and thus under "developer").
I had to add a few empty
__init__.py
files due to relative imports that didn't worked otherwise or due to cython otherwise creating wrong module names (which then fails on runtime).Also had to remove some code that relied on Cython env variables because I was not able to pass it Python version as an integer (cython has
-E
but that results in a str variable). For the same reason, I deleted old unused code for cygwin support.📝 Checklist
⌛ Dependencies