build/pkgs/tox: Update, require tox >= 4.2.7, update dependencies #36176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mkoeppe
changed the title
kwankyu
reviewed
Sep 7, 2023
build/pkgs/virtualenv/SPKG.rst
Outdated
| @@ -9,8 +9,6 @@ Virtual Python Environment builder | |||
| License | |||
| ------- | |||
|
|
|||
| MIT | |||
|
|
|||
| Upstream Contact | |||
There was a problem hiding this comment.
Why is the license info deleted?
kwankyu
reviewed
Sep 7, 2023
build/pkgs/tox/SPKG.rst
Outdated
| @@ -9,8 +9,6 @@ tox is a generic virtualenv management and test command line tool | |||
| License | |||
| ------- | |||
|
|
|||
| MIT | |||
|
|
|||
| Upstream Contact | |||
There was a problem hiding this comment.
Why the license info is deleted? It seems still valid.
|
It looks good to me as far as I check. I will set positive review after Build & Test passes here and locally, unless @orlitzky chimes in. |
|
Thank you! |
|
merge conflict |
…tools_wheel, not the ancient build/pkgs/setuptools
|
Documentation preview for this PR (built with commit d4bd789; changes) is ready! 🎉 |
|
Is "Build&Test using Conda" supposed to pass? What should I compare the result with? Does it pass on develop branch? |
|
"Build&Test using Conda" has been broken for a while now; a possible fix in #35986 is stuck |
|
OK then. |
|
Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies
bootstrap#36240 (merged here)pyproject.tomlfiles #36263 (merged here)