Meta-PR: Replace imports from sage.*.all for namespace packages #35110

mkoeppe · 2023-02-13T05:04:18Z

📚 Description

Fixes #34201

📝 Checklist

I have made sure that the title is self-explanatory and the description concisely explains the PR.
I have linked an issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

Depends on sage.{algebras,combinat,matroids}: Replace imports from sage.*.all for namespace packages #35090
Depends on sage.{topology,homology}: Replace imports from sage.*.all for namespace packages #35098
Depends on sage.{coding,groups}: Replace imports from sage.*.all for namespace packages #35099
Depends on sage.{functions,interfaces,symbolic}: Replace imports from sage.*.all for namespace packages #35105
Depends on sage.{arith,crypto,databases,dynamics,lfunctions,quadratic_forms}: Replace imports from sage.*.all for namespace packages #35106
Depends on sage.{finance,interacts,libs,numerical,stats,tests}: Replace imports from sage.*.all for namespace packages #35107

…xport of is_FiniteField

…eField_base

…precate_is_finitefield SageMath version 9.8.beta6, Release Date: 2022-12-21

…s,tests}

…his autogenerated file

…Q/;s/ Z as ZZ/ ZZ/;'

…me module

…Q/;s/ Z as ZZ/ ZZ/;'

…ce_imports_from_sage___all_for_namespace_packages SageMath version 9.8, Release Date: 2023-02-11

…__replace_imports_from_sage___all_for_namespace_packages SageMath version 10.0.beta0, Release Date: 2023-02-12

…_imports_from_sage___all_for_namespace_packages SageMath version 10.0.beta0, Release Date: 2023-02-12

…ic___replace_imports_from_sage___all_for_namespace_packages SageMath version 10.0.beta0, Release Date: 2023-02-12

…rical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages SageMath version 10.0.beta0, Release Date: 2023-02-12

…unctions,quadratic_forms} | xargs sed -i.bak 's/GCD as gcd/gcd/'

…lfunctions,quadratic_forms} | xargs sed -i.bak 's/XGCD as xgcd/xgcd/'

…rts_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

…___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

…sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

…mports_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

…s_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

…cs_tests___replace_imports_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

… warning to error again

src/.relint.yml: Allow .all imports in some more modules fixup

… in merge

…nitefield' into t/34955/sage__arith_crypto_databases_dynamics_lfunctions_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages

…s_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

… import

github-actions · 2023-03-13T04:38:19Z

Documentation preview for this PR is ready! 🎉
Built with commit: 34586ac

dimpase

lgtm

mkoeppe · 2023-03-14T23:29:37Z

Thanks!

### 📚 Description This is a follow-up on: - #35110 As preparation for #35322, which is changing more packages to implicit namespace packages, we remove `.all` imports from these packages throughout the Sage library. This is part of: - #29705     ### 📝 Checklist  - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies  - Depends on #35418 - Depends on #35358  URL: #35372 Reported by: Matthias Köppe Reviewer(s): Gonzalo Tornaría

mkoeppe and others added 27 commits December 18, 2022 13:40

sage.rings.finite_rings: Deprecate is_FiniteField, is_PrimeFiniteField

53ede8c

sage.rings.finite_rings: Make it a namespace package

8d4d8e5

src/sage/rings/finite_rings/finite_field_constructor.py: Restore re-e…

6ce26bc

…xport of is_FiniteField

src/sage/rings/finite_rings/hom_finite_field.pyx: Import ABC as Finit…

98a5484

…eField_base

sage.rings.finite_rings: Deprecate is_FiniteFieldElent

2e6b5ef

Fixups

3be7c97

Fixups

97a363e

Fixup: Elements of finite fields are not instances of FieldElement

0c01403

src/sage/crypto/mq/rijndael_gf.py: Fix imports

9f4d1c4

Merge tag '9.8.beta6' into t/32664/add_sage_rings_abc_finitefield__de…

9ebadcf

…precate_is_finitefield SageMath version 9.8.beta6, Release Date: 2022-12-21

sage -fiximports src/sage/algebras src/sage/combinat src/sage/matroids

bdf2f33

sage -fiximports src/sage/{topology,homology}

301a0d1

sage -fiximports src/sage/{functions,interfaces,symbolic}

21148e5

sage -fiximports src/sage/{finance,interacts,libs,numerical,statistic…

1e88c12

…s,tests}

src/sage/{numerical,tests}: Manual fixes to imports

572896d

sage -fiximports src/sage/stats

965dfc6

src/sage/libs/giac/auto-methods.pxi: Back out whitespace changes in t…

21b94ba

…his autogenerated file

git grep -l -E ' (Q as QQ|Z as ZZ)' | xargs sed -i.bak 's/ Q as QQ/ Q…

bd50b49

…Q/;s/ Z as ZZ/ ZZ/;'

sage.{algebras,combinat}: Consolidate imports from the same module

8e77597

src/sage/interfaces/sage0.py: Hide a legitimate .all import from relint

2870ffb

sage.{functions,interfaces,symbolic}: Consolidate imports from the sa…

70e5c66

…me module

git grep -l -E ' (Q as QQ|Z as ZZ)' | xargs sed -i.bak 's/ Q as QQ/ Q…

7305a7c

…Q/;s/ Z as ZZ/ ZZ/;'

Merge tag '9.8' into t/34946/sage__algebras_combinat_matroids___repla…

f8bf304

…ce_imports_from_sage___all_for_namespace_packages SageMath version 9.8, Release Date: 2023-02-11

Merge tag '10.0.beta0' into t/34946/sage__algebras_combinat_matroids_…

7bb289c

…__replace_imports_from_sage___all_for_namespace_packages SageMath version 10.0.beta0, Release Date: 2023-02-12

Merge tag '10.0.beta0' into t/34953/sage__topology_homology___replace…

effc538

…_imports_from_sage___all_for_namespace_packages SageMath version 10.0.beta0, Release Date: 2023-02-12

Merge tag '10.0.beta0' into t/34954/sage__functions_interfaces_symbol…

43c759d

…ic___replace_imports_from_sage___all_for_namespace_packages SageMath version 10.0.beta0, Release Date: 2023-02-12

Merge tag '10.0.beta0' into t/34957/sage__finance_interacts_libs_nume…

572f4fb

…rical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages SageMath version 10.0.beta0, Release Date: 2023-02-12

mkoeppe added s: needs review t: refactoring labels Feb 13, 2023

mkoeppe added this to the sage-10.0 milestone Feb 13, 2023

mkoeppe added 12 commits March 12, 2023 18:13

src/sage/crypto/public_key/blum_goldwasser.py: Fix up relative imports

feb6525

Replace relative imports by absolute imports because pytest

6e96393

Fix up syntax

4571804

git grep -l 'GCD as gcd' src/sage/{arith,crypto,databases,dynamics,lf…

9721de1

…unctions,quadratic_forms} | xargs sed -i.bak 's/GCD as gcd/gcd/'

git grep -l 'XGCD as xgcd' src/sage/{arith,crypto,databases,dynamics,…

f9f6542

…lfunctions,quadratic_forms} | xargs sed -i.bak 's/XGCD as xgcd/xgcd/'

Merge branch 't/34946/sage__algebras_combinat_matroids___replace_impo…

e2eb4af

…rts_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

Merge branch 't/34948/sage__coding_groups___replace_imports_from_sage…

a8d742d

…___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

Merge branch 't/34953/sage__topology_homology___replace_imports_from_…

2dc34c4

…sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

Merge branch 't/34954/sage__functions_interfaces_symbolic___replace_i…

93237d5

…mports_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

Merge branch 't/34955/sage__arith_crypto_databases_dynamics_lfunction…

436eaf3

…s_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

Merge branch 't/34957/sage__finance_interacts_libs_numerical_statisti…

3f33cb3

…cs_tests___replace_imports_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

src/.relint.yml (namespace_pkg_all_import): Skip all.py, upgrade from…

247bad9

… warning to error again

mkoeppe force-pushed the t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages branch from f2adb08 to 81b5806 Compare March 13, 2023 01:27

src/.relint.yml: Allow .all imports in some modules

d2be519

src/.relint.yml: Allow .all imports in some more modules fixup

mkoeppe force-pushed the t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages branch from 81b5806 to d2be519 Compare March 13, 2023 01:43

mkoeppe added 4 commits March 12, 2023 19:23

src/sage/rings/padics/padic_template_element.pxi: Restore import lost…

e62066f

… in merge

Merge branch 't/32664/add_sage_rings_abc_finitefield__deprecate_is_fi…

a9d9420

…nitefield' into t/34955/sage__arith_crypto_databases_dynamics_lfunctions_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages

Merge branch 't/34955/sage__arith_crypto_databases_dynamics_lfunction…

545c2d1

…s_quadratic_forms___replace_imports_from_sage___all_for_namespace_packages' into t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages

src/sage/rings/polynomial/integer_valued_polynomials.py: Replace .all…

34586ac

… import

mkoeppe requested a review from dimpase March 13, 2023 20:48

dimpase approved these changes Mar 14, 2023

View reviewed changes

dimpase added s: positive review and removed s: needs review labels Mar 14, 2023

vbraun merged commit 80511e1 into sagemath:develop Mar 26, 2023

kwankyu removed the s: positive review label Mar 26, 2023

mkoeppe mentioned this pull request Mar 28, 2023

Replace more .all imports #35372

Merged

5 tasks

mkoeppe deleted the t/34201/meta_ticket__replace_imports_from_sage___all_for_namespace_packages branch April 7, 2023 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Meta-PR: Replace imports from sage.*.all for namespace packages #35110

Meta-PR: Replace imports from sage.*.all for namespace packages #35110

mkoeppe commented Feb 13, 2023 •

edited

Loading

github-actions bot commented Mar 13, 2023

dimpase left a comment

mkoeppe commented Mar 14, 2023

Meta-PR: Replace imports from sage.*.all for namespace packages #35110

Meta-PR: Replace imports from sage.*.all for namespace packages #35110

Conversation

mkoeppe commented Feb 13, 2023 • edited Loading

📚 Description

📝 Checklist

⌛ Dependencies

github-actions bot commented Mar 13, 2023

dimpase left a comment

Choose a reason for hiding this comment

mkoeppe commented Mar 14, 2023

mkoeppe commented Feb 13, 2023 •

edited

Loading