Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Linux Incremental: Fix "toctree contains reference to nonexisting document" #37786

Closed
mkoeppe opened this issue Apr 11, 2024 · 0 comments · Fixed by #38144
Closed

CI Linux Incremental: Fix "toctree contains reference to nonexisting document" #37786

mkoeppe opened this issue Apr 11, 2024 · 0 comments · Fixed by #38144
Labels
c: scripts t: bug
Milestone
sage-10.4

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Apr 11, 2024 •
edited
Loading

Seen in https://github.com/sagemath/sage/actions/runs/8626379356/job/23644513913?pr=37570#step:11:2933

#24 4063.0   [sagemath_doc_html-none]   [spkg-install] [structure] updating environment: 0 added, 1 changed, 31 removed
#24 4063.0   [sagemath_doc_html-none]   [spkg-install] [valuation] /sage/src/doc/en/reference/valuations/index.rst:186: WARNING: toctree contains reference to nonexisting document 'sage/rings/valuation/value_group'
#24 4063.0   [sagemath_doc_html-none]   [spkg-install] [valuation] /sage/src/doc/en/reference/valuations/index.rst:186: WARNING: toctree contains reference to nonexisting document 'sage/rings/valuation/valuation'

(A second round of building sagemath_doc_html in the same run then completes without error.)

Another variant seen in https://github.com/sagemath/sage/actions/runs/8626379356/job/23644514413?pr=37570#step:11:4173:

#24 7383.6   [sagemath_doc_html-none]   [spkg-install]     env = pickle.load(f)
#24 7383.6   [sagemath_doc_html-none]   [spkg-install]           ^^^^^^^^^^^^^^
#24 7383.6   [sagemath_doc_html-none]   [spkg-install] AttributeError: Can't get attribute '_stable_repr_object' on <module 'sphinx.builders.html' from '/sage/local/var/lib/sage/venv-python3.11/lib/python3.11/site-packages/sphinx/builders/html/__init__.py'>
#24 7383.6   [sagemath_doc_html-none]   [spkg-install]
This was referenced Apr 14, 2024
Merged
Merged
Merged
@orlitzky orlitzky mentioned this issue Apr 17, 2024
Merged
5 tasks
@mkoeppe mkoeppe mentioned this issue Apr 28, 2024
Merged
5 tasks
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 3, 2024
@mkoeppe mkoeppe mentioned this issue Jun 5, 2024
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Jun 8, 2024
sagemathgh-38144: CI: Fix handling of deletions/renames; Build&Test: …
cfb5065 
…Uninstall/build changed packages; Linux Incremental: Update platforms

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixes handling of deletions/renames
- https://groups.google.com/g/sage-devel/c/tw6J8vU7IY0/m/IZxuGW8gBQAJ
- sagemath#36892 (comment)

When changes to packages are made, "CI Build&Test" now uses the same
logic as "CI Linux Incremental" for determining what SPKGs to uninstall
(so that spkg-configure.m4 is re-run) and what optional SPKGs to
install.

We update the platforms of "CI Linux Incremental" and remove the default
platform from there, to remove the duplication with "CI Build&Test".

- Also apparently fixes sagemath#37786

For a test run with a PR that actually makes changes to packages, see
- sagemath#38147

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38144
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: scripts t: bug
Projects
None yet
Milestone
sage-10.4
1 participant
@mkoeppe