Skip to content

Commit

Permalink
gh-35377: build/pkgs/openblas/spkg-configure.m4: Reject version 0.3.22
Browse files Browse the repository at this point in the history
    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes #12345", use "Add a new method to
multiply two integers" -->

### 📚 Description
openblas 0.3.22 is broken, see:
- #35371
- scipy/scipy#18208
- OpenMathLib/OpenBLAS#3976

We reject it.

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #35377
Reported by: Matthias Köppe
Reviewer(s): John H. Palmieri
  • Loading branch information
Release Manager committed Apr 4, 2023
2 parents 519b62c + 200c626 commit 8a355d2
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion build/pkgs/openblas/spkg-configure.m4
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ SAGE_SPKG_CONFIGURE([openblas], [
m4_pushdef([SAGE_OPENBLAS_MIN_VERSION_MINOR], [2])
m4_pushdef([SAGE_OPENBLAS_MIN_VERSION_MICRO], [20])
m4_pushdef([SAGE_OPENBLAS_MIN_VERSION], [SAGE_OPENBLAS_MIN_VERSION_MAJOR.SAGE_OPENBLAS_MIN_VERSION_MINOR.SAGE_OPENBLAS_MIN_VERSION_MICRO])
PKG_CHECK_MODULES([OPENBLAS], [openblas >= ]SAGE_OPENBLAS_MIN_VERSION, [
dnl Reject openblas 0.3.22 - https://github.com/sagemath/sage/pull/35371
m4_pushdef([SAGE_OPENBLAS_LT_VERSION_MAJOR], [0])
m4_pushdef([SAGE_OPENBLAS_LT_VERSION_MINOR], [3])
m4_pushdef([SAGE_OPENBLAS_LT_VERSION_MICRO], [22])
m4_pushdef([SAGE_OPENBLAS_LT_VERSION], [SAGE_OPENBLAS_LT_VERSION_MAJOR.SAGE_OPENBLAS_LT_VERSION_MINOR.SAGE_OPENBLAS_LT_VERSION_MICRO])
PKG_CHECK_MODULES([OPENBLAS], [openblas >= ]SAGE_OPENBLAS_MIN_VERSION [openblas < ]SAGE_OPENBLAS_LT_VERSION, [
LIBS="$OPENBLAS_LIBS $LIBS"
CFLAGS="$OPENBLAS_CFLAGS $CFLAGS"
PKG_CHECK_VAR([OPENBLASPCDIR], [openblas], [pcfiledir], [
Expand Down Expand Up @@ -74,6 +79,13 @@ SAGE_SPKG_CONFIGURE([openblas], [
< 10000 * ]]SAGE_OPENBLAS_MIN_VERSION_MAJOR[[
+ 100 * ]]SAGE_OPENBLAS_MIN_VERSION_MINOR[[
+ ]]SAGE_OPENBLAS_MIN_VERSION_MICRO[[)
return 1;
if ( 10000 * version[0]
+ 100 * version[1]
+ version[2]
>=10000 * ]]SAGE_OPENBLAS_LT_VERSION_MAJOR[[
+ 100 * ]]SAGE_OPENBLAS_LT_VERSION_MINOR[[
+ ]]SAGE_OPENBLAS_LT_VERSION_MICRO[[)
return 1;]])
], [AS_VAR_SET([HAVE_OPENBLAS], [yes])], [AS_VAR_SET([HAVE_OPENBLAS], [no])],
[AS_VAR_SET([HAVE_OPENBLAS], [yes])])
Expand Down

0 comments on commit 8a355d2

Please sign in to comment.