Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Safe Creation #988

Merged
merged 42 commits into from
Nov 24, 2022
Merged

[Epic] Safe Creation #988

merged 42 commits into from
Nov 24, 2022

Commits on Oct 27, 2022

  1. feat: new creation design + step 1

    iamacook authored and usame-algan committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    ee0d266 View commit details
    Browse the repository at this point in the history
  2. fix: widget width

    iamacook authored and usame-algan committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    c1b9731 View commit details
    Browse the repository at this point in the history
  3. refactor: combine components

    iamacook authored and usame-algan committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    649be2c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    399563f View commit details
    Browse the repository at this point in the history
  5. fix: missing padding

    iamacook authored and usame-algan committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    96bb532 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    06f2718 View commit details
    Browse the repository at this point in the history
  7. [Safe Creation] Owner step (#989)

    * feat: basic step 2 implementation
    
    Co-authored-by: iamacook <aaron@safe.global>
    2 people authored and usame-algan committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    fa66271 View commit details
    Browse the repository at this point in the history
  8. feat: creation info widget (#960)

    * feat: creation info widget
    
    * fix: Remove demo page
    
    Co-authored-by: Usame Algan <usame@safe.global>
    iamacook and usame-algan committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    614ee1b View commit details
    Browse the repository at this point in the history
  9. Safe creation stepper (#992)

    A new CardStepper component which controls the steps for new safe creation which can
    - go back and forth
    - jump to a specific step
    - set an initial step
    - set initial values
    - renders a progress bar
    - step data is stored in an object with a generic type
      - the update functions (onBack, onSubmit) use Partials of that type such that each step does not need to submit the full data
    
    change /demo route to /create-safe
    
    Co-authored-by: Usame Algan <usame@safe.global>
    schmanu and usame-algan authored Oct 27, 2022
    Configuration menu
    Copy the full SHA
    0b379c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Review step redesign (#993)

    * feat: new create safe review step
    
    * calculate total gas fee
    
    * fill the form values
    
    * refactor review rows
    
    * fix: implement Figma designs
    
    * fix: background-color on network fee
    
    * avoid infinite rerendering
    
    * integrate review step in new Stepper
    
    * style: visual tweaks
    DiogoSoaress authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    7ac11b1 View commit details
    Browse the repository at this point in the history
  2. fix: Create safe layout adjustments (#997)

    * fix: Create safe layout adjustments
    
    * fix: overview widget margin top
    
    * fix: Move overview widget to top on mobile
    usame-algan authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    8c0931c View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Configuration menu
    Copy the full SHA
    e5b6176 View commit details
    Browse the repository at this point in the history
  2. feat: AB testing system (#1013)

    * feat: AB testing system
    
    * fix: remove reset function + test `AbTest` value
    
    * Refactor: sync useLocalStorage across components and tabs (#977)
    
    * Refactor: external store in useLocalStorage
    
    * Comment
    
    * Sync separately
    
    * Use the storage event for syncing
    
    * Rm comment
    
    * Restore prev behavior wrt undefined
    
    * Simplify the undefined check
    
    * Allow undefined and rm initialValue
    
    * Don't set undefined
    
    * Local storage to return null when not found
    
    * Initial value
    
    * Rm initial value again
    
    * usePendingCreation
    
    * Rm redundant code
    
    * Refactor: external store in useLocalStorage (#1014)
    
    Refactor: external store in useLocalStorage
    
    * feat: create `useABTesting` hook for setting event
    
    * fix: reorganise structure
    
    Co-authored-by: katspaugh <381895+katspaugh@users.noreply.github.com>
    iamacook and katspaugh authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8f75ac1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba2f7ca View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. [Create Safe] feat: Connect wallet step (#1006)

    * fix: Add connect wallet step to safe creation
    
    * fix: Remove unused method
    
    * fix: Reuse components, adjust modal zIndex
    
    * fix: Only run onConnect callback if there was no error when connecting a wallet
    
    * fix: Set wallet owner in form on connect
    
    * fix: Check for connected wallet
    
    * style: Use onboard zindex variable
    usame-algan authored Nov 2, 2022
    Configuration menu
    Copy the full SHA
    9be5b07 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. [Create Safe] add overview and CreateSafeInfo widget (#1002)

    * add overview and CreateSafeInfo widget
    
    - displays safe name and connected wallet during owner setup
    - displays hints for each step + dynamic hints during owner and threshold setup
    - state is pulled up into the CreateSafe component and update functions passed into the owner step
    
    * step static tips are collapsed by default
    
    * navigate tips logic
    
    * reverse expanded logic
    
    * restyle InfoWidget
    
    * remove the add mobile owner row
    
    * remove flickering when opening the accordion
    
    * fix keys
    
    * add hover style to the Accordion expand icon
    
    * Accordion summary bold when expanded
    
    * style: PR comments
    
    * fix empty form data name
    
    * simplify map key
    
    * link to Safe setup article
    
    * change allOwners logic
    
    * mv sx to css modules
    
    * add current chain in Overview widget
    
    Co-authored-by: Diogo Soares <diogo.lsoares@gmail.com>
    schmanu and DiogoSoaress authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    6b05e27 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. [Create Safe] feat: Status view redesign (#1018)

    * feat: Implement create safe status redesign
    
    * style: Add animated loading spinner
    
    * fix: Simplify conditions
    
    * add: animate into css safe logo
    
    * fix: use numeric enum for simpler conditions, adjust animated logo sizes
    
    * fix: Display dialog after safe creation
    
    * fix: Feedback
    
    * fix: Better name for query param
    
    Co-authored-by: schmanu <manu@safe.global>
    usame-algan and schmanu authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    872f5f9 View commit details
    Browse the repository at this point in the history
  2. [Safe creation] Creation links tooltips (#1061)

    * add link to tip
    
    * add missing tooltips
    
    * update copy
    
    * use SvgIcon to inherit viewBox
    
    * fix: inherit `fill`
    
    Co-authored-by: iamacook <aaron@safe.global>
    DiogoSoaress and iamacook authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    bd444dc View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Configuration menu
    Copy the full SHA
    76fd913 View commit details
    Browse the repository at this point in the history
  2. [Safe Creation] Layout adjustments (#1063)

    * style: Safe Creation layout
    
    * fix: Align threshold text
    usame-algan authored Nov 7, 2022
    Configuration menu
    Copy the full SHA
    a130210 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. [Create Safe] Handle wallet connection (#1087)

    * fix: Handle wallet connection when creating safe
    
    * fix: Only watch threshold
    
    * refactor: Rename useSetCreationStep to useSyncSafeCreationStep
    
    * fix: Use formState.isValid
    
    * fix: Add tests for useSyncSafeCreationStep
    usame-algan authored Nov 8, 2022
    Configuration menu
    Copy the full SHA
    a7ee64d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. fix: Show error notifications in safe creation (#1135)

    * fix: Show error notifications in safe creation
    
    * fix: Add closeByGroupKey action to notification slice
    usame-algan authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    24575fc View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. fix: Safe creation issues (#1180)

    * fix: Navigate back to the welcome page on cancel
    
    * fix: Reuse NameInput for new form
    
    * fix: Use currentColor for icons
    usame-algan authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    394a1d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92815bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e7bedd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f612622 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. fix: reduce threshold when removing owner (#1181)

    * fix: reduce threshold when removing owner
    
    * fix: use enum for all field names
    
    * fix: reduce code
    iamacook authored Nov 18, 2022
    Configuration menu
    Copy the full SHA
    18482b8 View commit details
    Browse the repository at this point in the history
  2. Safe creation text updates (#1198)

    * fix: Update text and layout for step 0
    
    * fix: Update text for step 2 and 3, show copy and explorer icons for addresses
    
    * fix: Update text for status messages
    
    * fix: Update hint texts
    
    * fix: Update creation modal text, add dynamic values
    usame-algan authored Nov 18, 2022
    Configuration menu
    Copy the full SHA
    477e0b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Configuration menu
    Copy the full SHA
    bd68151 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. fix: Safe Creation color issues (#1204)

    * fix: Safe Creation color issues
    
    * chore: Add TODO
    
    * fix: Remove static colors and use palette directly
    usame-algan authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    0915f52 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bf18e1 View commit details
    Browse the repository at this point in the history
  3. fix: Add missing safe creation events (#1212)

    * fix: Add missing safe creation events
    
    * fix: Add new events for hints
    usame-algan authored Nov 21, 2022
    Configuration menu
    Copy the full SHA
    4a10f47 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. fix: Watch safe creation tx even without a connected wallet (#1215)

    * fix: Watch safe creation tx even without a connected wallet
    
    * fix it in the old safe creation flow too
    
    * fix: failing test
    
    * fix: Add additional test
    usame-algan authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    60b7df3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    309f8f0 View commit details
    Browse the repository at this point in the history
  3. fix: Only watch safe creation tx once (#1223)

    * fix: Only watch safe creation tx once
    
    * fix: Detect if tx reverted when ethers throws error
    usame-algan authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    8d630f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. refactor: Remove unused code that was duplicated (#1230)

    * refactor: Remove unused code that was duplicated
    
    * fix: Revert ab test removal
    
    * refactor: Remove unused StepCard component
    
    * fix: Update links to safe.global
    
    * fix: Set link to safe creation for ab testing
    usame-algan authored Nov 23, 2022
    Configuration menu
    Copy the full SHA
    e2587ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99c5ce0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3dddd54 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Configuration menu
    Copy the full SHA
    39cd835 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5bf3a52 View commit details
    Browse the repository at this point in the history
  3. fix: Safe cration text changes (#1239)

    * fix: Safe cration text changes
    
    * fix: Adjust safe indexed message
    usame-algan authored Nov 24, 2022
    Configuration menu
    Copy the full SHA
    6507814 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9d9354c View commit details
    Browse the repository at this point in the history