Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Multichain): empty setup data #4255

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Sep 26, 2024

What it solves

The transaction service returns "0x" as setupData for some Safes in case of indexing issues.

How this PR fixes it

Shows a custom error in case the setupData is 0x instead of running into an ethers error.

How to test it

  • Use impersonator to impersonate an owner of this Safe: bnb:0xEAce5e6aC77210af7B26f315925DF83A3f8477c0
  • Try to add a new network in the sidebar

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 26, 2024

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 990.16 KB (🟡 +35.67 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -24.37 KB) 990.65 KB
/address-book 26.09 KB (🟡 +5 B) 1016.24 KB
/apps 50.18 KB (🟡 +174 B) 1.02 MB
/apps/custom 41.81 KB (🟡 +174 B) 1.01 MB
/apps/open 54.74 KB (🟡 +37 B) 1.02 MB
/balances 31 KB (🟡 +73 B) 1021.16 KB
/balances/nfts 19.18 KB (-1 B) 1009.34 KB
/home 60.96 KB (🟡 +1.24 KB) 1.03 MB
/new-safe/advanced-create 36.49 KB (🟡 +1.36 KB) 1 MB
/new-safe/create 35.75 KB (🟡 +1.36 KB) 1 MB
/new-safe/load 16.41 KB (🟡 +10 B) 1006.57 KB
/settings/notifications 27.02 KB (-2 B) 1017.17 KB
/settings/safe-apps 25.56 KB (🟡 +38 B) 1015.72 KB
/settings/setup 35.98 KB (🟡 +5 B) 1 MB
/transactions/tx 21.07 KB (-2 B) 1011.22 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.22% 12418/15875
🔴 Branches
58.17% (+0.01% 🔼)
3225/5544
🟡 Functions 65.7% 1961/2985
🟡 Lines 79.69% 11204/14060

Test suite run success

1549 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from c4a298b

@schmanu schmanu merged commit 2531ac1 into epic/multichain-safes Sep 26, 2024
13 checks passed
@schmanu schmanu deleted the fix/empty-setup-data branch September 26, 2024 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants