Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Multichain): simplify multichain naming options [SW-187] [SW-221] [SW-211] #4243

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Sep 24, 2024

What it solves

Resolves:

How this PR fixes it

  • Removes the ability to rename multichain safes from the safe list
  • Removes the chain indicator from the modal when renaming a multichain safe
  • Removes the name input from the modal when replaying a safe on a new network.

How to test it

  • Replay a safe from the sidebar or the network menu in the navbar.
  • You should not be able to choose the name of the safe. Once created it should have the same name as the original safe.
  • Click the context menu of an individual safe within a multichain group.
  • You should not see the option to rename.
  • Clicking on the context menu of the multichain overview should give the ability to rename the entire group at once. There should be no chain indicator in the rename modal.

Screenshots

Renaming multichain overview:
image

Replaying to a new network:
image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 24, 2024

Branch preview

⏳ Deploying a preview site...

Copy link

github-actions bot commented Sep 24, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 991.47 KB (🟡 +36.96 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -24.37 KB) 991.97 KB
/address-book 26.1 KB (🟡 +4 B) 1017.57 KB
/apps/open 54.74 KB (-1 B) 1.02 MB
/balances 31 KB (🟡 +16 B) 1022.47 KB
/balances/nfts 19.18 KB (-1 B) 1010.65 KB
/home 60.89 KB (🟡 +687 B) 1.03 MB
/new-safe/advanced-create 36.5 KB (🟡 +1.35 KB) 1 MB
/new-safe/create 35.76 KB (🟡 +1.35 KB) 1 MB
/new-safe/load 16.42 KB (🟡 +9 B) 1007.89 KB
/settings/setup 35.98 KB (🟡 +5 B) 1 MB
/transactions 73.52 KB (-2 B) 1.04 MB
/transactions/history 73.49 KB (-2 B) 1.04 MB
/transactions/tx 21.07 KB (-1 B) 1012.54 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 24, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.06% (-0% 🔻)
12427/15920
🔴 Branches 58.06% 3222/5549
🟡 Functions
65.26% (-0.01% 🔻)
1952/2991
🟡 Lines
79.54% (-0.01% 🔻)
11209/14093
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / addressBookSlice.ts
92.11% (+0.99% 🔼)
66.67% (+3.03% 🔼)
88.89% (-1.11% 🔻)
92.59% (-1.35% 🔻)

Test suite run success

1543 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from 54d4803

@jmealy jmealy requested a review from schmanu September 24, 2024 13:37
@jmealy jmealy marked this pull request as ready for review September 24, 2024 13:39
@jmealy jmealy changed the title Multichain naming Feat(Multichain): simplify multichain naming options [SW-187] [SW-221] [SW-211] Sep 24, 2024
Copy link

Copy link

Copy link

@@ -42,9 +42,9 @@ function EntryDialog({

const submitCallback = handleSubmit((data: AddressEntry) => {
if (chainIds) {
dispatch(upsertMultichainAddressBookEntry({ ...data, chainIds }))
dispatch(upsertAddressBookEntries({ ...data, chainIds }))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We could simplify this to

      dispatch(upsertAddressBookEntries({ ...data, chainIds: chainIds ?? [currentChainId] }))

And remove the if-else statement.

@jmealy jmealy merged commit 54f7c47 into epic/multichain-safes Sep 25, 2024
9 of 12 checks passed
@jmealy jmealy deleted the multichain-naming branch September 25, 2024 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants