chore: Add no-unused-vars and await-thenable eslint rules #4242
Conversation
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Eleven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
katspaugh
changed the title
| @@ -82,7 +82,7 @@ describe('CheckWallet', () => { | |||
| ;(useIsSafeOwner as jest.MockedFunction<typeof useIsSafeOwner>).mockReturnValueOnce(true) | |||
|
|
|||
| const renderButtonWithNetworkCheck = () => | |||
| render(<CheckWallet checkNetwork={true}>{(isOk) => <button disabled={true}></button>}</CheckWallet>) | |||
| render(<CheckWallet checkNetwork={true}>{() => <button disabled={true}></button>}</CheckWallet>) | |||
There was a problem hiding this comment.
Should it really be always true?
Should the disabled state not depend on the isOk?
| render(<CheckWallet checkNetwork={true}>{() => <button disabled={true}></button>}</CheckWallet>) | |
| render(<CheckWallet checkNetwork={true}>{(isOk) => <button disabled={!isOk}></button>}</CheckWallet>) |
There was a problem hiding this comment.
Good catch! Pushed the fix. Now the test also makes sense again.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1485 tests passing in 203 suites. Report generated by 🧪jest coverage report action from 6910cf8 |
…er in TxFilterForm test
What it solves
Resolves #4238
How this PR fixes it
userEventinstead offireEventto fix promise issuesactfrom react because of deprecationvalidatefromNameInputas its not being usedChecklist