Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update lint action #4230

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Chore: update lint action #4230

merged 7 commits into from
Sep 23, 2024

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Sep 23, 2024

What it solves

Test and lint jobs complain about missing permissions in dependabot PRs:

Screenshot 2024-09-23 at 11 59 23

Example run:
https://github.com/safe-global/safe-wallet-web/actions/runs/10985821075/job/30498269458?pr=4223


This PR also reverts the automatic upgrade of the fake-indexeddb package which causes a test breakage.

Copy link

github-actions bot commented Sep 23, 2024

Copy link

github-actions bot commented Sep 23, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@katspaugh katspaugh marked this pull request as draft September 23, 2024 11:25
@katspaugh katspaugh changed the title Chore: add check write permissions to test and lint CI jobs Chore: update lint action Sep 23, 2024
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.25% (+0.23% 🔼)
12020/15361
🔴 Branches
58.23% (+0.02% 🔼)
3085/5298
🟡 Functions
65.32% (+0.45% 🔼)
1893/2898
🟡 Lines
79.77% (+0.22% 🔼)
10851/13603

Test suite run success

1485 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 6373333

@katspaugh katspaugh marked this pull request as ready for review September 23, 2024 13:47
@katspaugh katspaugh merged commit 815cb89 into dev Sep 23, 2024
15 checks passed
@katspaugh katspaugh deleted the checkwrite branch September 23, 2024 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants