Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Staking): display correct value for withdrawal #4219

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

compojoom
Copy link
Collaborator

What it solves

Display correct value to withdraw. The Kiln API was not returning the correct value for the amount the user was going to withdraw. They've correct this and the fix was implemented on CGW, so had to update our UI as well.

Resolves #

How this PR fixes it

The rewards prop was removed from the cgw endpoint. value now returns the correct net(minus any fees) reward

How to test it

Withdraw a reward(claim) -> you should see the same value as displayed in the kiln widget.

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 20, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 954.25 KB (-3 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.23% (-0.01% 🔻)
12013/15356
🔴 Branches
58.2% (-0.03% 🔻)
3081/5294
🟡 Functions
65.27% (-0.01% 🔻)
1891/2897
🟡 Lines
79.75% (-0.01% 🔻)
10845/13599
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / transaction-guards.ts
69.27% (-0.47% 🔻)
33.87% (-3.05% 🔻)
67.8% (-0.54% 🔻)
70.68% (-0.43% 🔻)
🟢
... / useTxPendingStatuses.ts
83.64% (-0.91% 🔻)
68.33% (-1.67% 🔻)
75%
92.63% (-1.05% 🔻)

Test suite run success

1485 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 665960f

@katspaugh katspaugh changed the title fix(stake): display correct value for withdrawal fix(Staking): display correct value for withdrawal Sep 20, 2024
@compojoom compojoom merged commit 91f1054 into dev Sep 20, 2024
16 checks passed
@compojoom compojoom deleted the fix-withdraw-wrong-value branch September 20, 2024 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants