Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staking] feat: add stake button, help tooltip; fix withdraw status display issues #4186

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

compojoom
Copy link
Collaborator

@compojoom compojoom commented Sep 16, 2024

What it solves

  • hide "active in" if stake validation has started
  • hide "Est. exit time" if ready to wirthdraw stake
  • add help tooltip next to withdraw in
  • add stake button on "assets" page

Resolves #

How this PR fixes it

How to test it

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 16, 2024

@compojoom compojoom changed the title Miscellaniuos stake stuff Miscellaneous stake stuff Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 16, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 953.93 KB (🟡 +11 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fourteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.18 KB (-1 B) 1004.11 KB
/apps/custom 41.81 KB (-1 B) 995.75 KB
/balances 30.99 KB (🟡 +336 B) 984.92 KB
/balances/nfts 19.18 KB (🟡 +1 B) 973.12 KB
/settings 451 B (🟡 +1 B) 954.38 KB
/settings/appearance 8.04 KB (🟢 -1 B) 961.97 KB
/settings/data 7.56 KB (🟢 -1 B) 961.5 KB
/settings/environment-variables 9.15 KB (🟡 +2 B) 963.08 KB
/settings/notifications 27.03 KB (-2 B) 980.97 KB
/settings/security 8.09 KB (🟡 +1 B) 962.02 KB
/settings/setup 35.98 KB (🟡 +1 B) 989.91 KB
/transactions 73.52 KB (-1 B) 1 MB
/transactions/history 73.48 KB (-1 B) 1 MB
/transactions/queue 31.26 KB (-1 B) 985.19 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.26% (+0.04% 🔼)
12014/15352
🔴 Branches
58.24% (-0.02% 🔻)
3083/5294
🟡 Functions
65.33% (+0.01% 🔼)
1892/2896
🟡 Lines
79.78% (+0.05% 🔼)
10846/13595
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / useIsSwapFeatureEnabled.ts
100% 50% 100% 100%
🟢
... / stake.ts
75% 100% 100% 100%
🟡
... / index.tsx
70.59% 0% 0% 75%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
100%
72.22% (-2.78% 🔻)
100% 100%

Test suite run success

1485 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 12ad0b3

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a semantic prefix to the PR title (according to https://www.conventionalcommits.org/en/v1.0.0/). Cheers!

@compojoom compojoom force-pushed the fix-stake-miscellanious branch 2 times, most recently from 3265281 to 73694b4 Compare September 17, 2024 13:59
@compojoom compojoom changed the title Miscellaneous stake stuff feat: add stake button, help tooltip; fix withdraw status display issues Sep 17, 2024
@compojoom compojoom marked this pull request as ready for review September 17, 2024 14:21
@katspaugh katspaugh changed the title feat: add stake button, help tooltip; fix withdraw status display issues [Staking] feat: add stake button, help tooltip; fix withdraw status display issues Sep 17, 2024
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@compojoom compojoom merged commit ac04fba into dev Sep 19, 2024
16 checks passed
@compojoom compojoom deleted the fix-stake-miscellanious branch September 19, 2024 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants