Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legal: update the terms page [SW-185] #4178

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Legal: update the terms page [SW-185] #4178

merged 2 commits into from
Sep 16, 2024

Conversation

katspaugh
Copy link
Member

What it solves

A few minor edits on the Terms page.

Copy link

github-actions bot commented Sep 16, 2024

Copy link

github-actions bot commented Sep 16, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Sep 16, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 949.59 KB (🟢 -4.03 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.19 KB (🟡 +2 B) 999.78 KB
/apps/custom 41.8 KB (🟡 +2 B) 991.38 KB
/apps/open 53.58 KB (🟢 -1.16 KB) 1003.17 KB
/balances 30.64 KB (🟢 -4 B) 980.23 KB
/home 60.32 KB (🟡 +69 B) 1009.91 KB
/settings/safe-apps 25.55 KB (🟡 +2 B) 975.14 KB
/settings/setup 35.96 KB (🟡 +3 B) 985.55 KB
/swap 646 B (🟢 -77 B) 950.22 KB
/terms 11.18 KB (🟢 -60 B) 960.77 KB
/transactions 73.83 KB (🟡 +374 B) 1023.42 KB
/transactions/history 73.8 KB (🟡 +376 B) 1023.39 KB
/transactions/messages 39.2 KB (🟡 +79 B) 988.79 KB
/transactions/msg 29.58 KB (🟡 +79 B) 979.17 KB
/transactions/queue 31.3 KB (🟡 +79 B) 980.89 KB
/transactions/tx 21.13 KB (🟡 +79 B) 970.72 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 16, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.45% 11859/15116
🔴 Branches 59% 3042/5156
🟡 Functions 65.82% 1885/2864
🟡 Lines 79.89% 10701/13394

Test suite run success

1483 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 75a9952

@katspaugh katspaugh changed the title Legal: update the terms page Legal: update the terms page [SW-185] Sep 16, 2024
Copy link

<ExternalLink href={AppRoutes.terms}>Terms & Conditions</ExternalLink> (last updated August 2024) and the
use of necessary cookies. By clicking &quot;Accept all&quot; you additionally agree to the use of Beamer
and Analytics cookies as listed below. <ExternalLink href={AppRoutes.cookie}>Cookie policy</ExternalLink>
<ExternalLink href={AppRoutes.terms}>Terms & Conditions</ExternalLink> (last updated September 2024) and
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include last updated month into the terms slice, otherwise it has to be hardcoded here and on the terms page.

@compojoom
Copy link
Collaborator

compojoom commented Sep 16, 2024

How about we close this in favour of #4183 ?

Although do we now always need to have the date in the cookieAndTermBanner?

@katspaugh katspaugh merged commit 5d8992c into release Sep 16, 2024
12 of 17 checks passed
@katspaugh katspaugh deleted the terms branch September 16, 2024 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants