Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multichain] fix: allow activating Safes as non-owner #4176

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Sep 16, 2024

What it solves

Allows activating Safe accounts as non owner and for multisig counterfactual Safes.

How this PR fixes it

Adds allowNonOwner to CheckWallet within the ActivateAccountFlow

How to test it

  • Create a m/n counterfactual Safe
  • Activate it

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu changed the title fix: allow activating Safes as non-owner [Multichain] fix: allow activating Safes as non-owner Sep 16, 2024
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 989.07 KB (🟡 +35.45 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 507 B (🟢 -24.36 KB) 989.57 KB
/address-book 26.11 KB (🟡 +3 B) 1015.19 KB
/apps/open 54.74 KB (🟡 +2 B) 1.02 MB
/balances 30.64 KB (-3 B) 1019.71 KB
/home 60.28 KB (🟡 +30 B) 1.02 MB
/new-safe/advanced-create 36.51 KB (🟡 +1.37 KB) 1 MB
/new-safe/create 35.76 KB (🟡 +1.36 KB) 1 MB
/new-safe/load 16.38 KB (🟢 -7 B) 1005.46 KB
/settings/modules 9.76 KB (🟢 -1 B) 998.84 KB
/settings/setup 35.96 KB (🟡 +1 B) 1 MB
/share/safe-app 9.72 KB (🟢 -2 B) 998.79 KB
/transactions 73.47 KB (🟡 +2 B) 1.04 MB
/transactions/history 73.44 KB (🟡 +2 B) 1.04 MB
/transactions/queue 31.22 KB (🟡 +2 B) 1020.3 KB
/transactions/tx 21.05 KB (🟡 +2 B) 1010.13 KB
/welcome 6.77 KB (🟢 -1 B) 995.84 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.94% (+0.01% 🔼)
12283/15759
🔴 Branches
58.13% (+0.02% 🔼)
3179/5469
🟡 Functions 65.17% 1931/2963
🟡 Lines
79.39% (+0.01% 🔼)
11089/13967

Test suite run success

1524 tests passing in 206 suites.

Report generated by 🧪jest coverage report action from 0ea88a4

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schmanu schmanu merged commit b0d17ea into epic/multichain-safes Sep 17, 2024
11 of 14 checks passed
@schmanu schmanu deleted the fix/activate-multisig-accounts branch September 17, 2024 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants